Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the bundle size of attachments preview. #1124

Closed
Tracked by #1123
deepakjosp opened this issue May 31, 2024 · 0 comments · Fixed by #1125 or #1137
Closed
Tracked by #1123

Reduce the bundle size of attachments preview. #1124

deepakjosp opened this issue May 31, 2024 · 0 comments · Fixed by #1125 or #1137
Assignees
@deepakjosp
Labels
0.75D Estimate - 6 hours PR The issue has a PR associated with it. working A branch associated with this issue is created.

Comments

@deepakjosp
Copy link
Contributor

deepakjosp commented May 31, 2024 •
edited
Loading

Part of #1123

  • We use the react-doc-viewer package for showing the previews for attachments. This contributes to a significant amount of bundle size.
  • Verify that if the attachments feature is not enabled, the package is not loaded into the main bundle.
  • Hand-pick the required renderers from react-doc-viewer instead of using the DocViewerRenderers to load all renderers.
@deepakjosp deepakjosp self-assigned this May 31, 2024
@deepakjosp deepakjosp mentioned this issue May 31, 2024
Closed
7 tasks
@neetogit-bot neetogit-bot bot added working A branch associated with this issue is created. PR The issue has a PR associated with it. labels May 31, 2024
@deepakjosp deepakjosp mentioned this issue May 31, 2024
Merged
4 tasks
@deepakjosp deepakjosp added the 0.75D Estimate - 6 hours label May 31, 2024
@neetogit-bot neetogit-bot bot added working A branch associated with this issue is created. and removed working A branch associated with this issue is created. labels Jun 5, 2024
@deepakjosp deepakjosp mentioned this issue Jun 5, 2024
Merged
4 tasks
@deepakjosp deepakjosp mentioned this issue Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepakjosp deepakjosp

Labels
0.75D Estimate - 6 hours PR The issue has a PR associated with it. working A branch associated with this issue is created.
Projects
None yet
Milestone
No milestone
1 participant
@deepakjosp