New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to skip mzml conversion #370

Closed

sooheon opened this issue May 2, 2024 · 1 comment · Fixed by #373

Labels

dia analysis enhancement good first issue release 1.3

sooheon commented May 2, 2024 •

edited

Loading

mzml conversion takes up a significant portion of runtime, and dia-nn now supports using .raw directly: https://github.com/vdemichev/DiaNN?tab=readme-ov-file#raw-data-formats

sooheon added the enhancement label

Member

ypriverol commented May 2, 2024

Thanks for the issue @sooheon we will work on it for the next release, however, some of the downsides of not converting are related with:

pmultiqc will not work because we don't have easy access to RAW data from Python.
Other components in the pipeline that use mzML will not work.

But agree, if the main idea is to speed-up DIANN, then we should make sure that we can read natively RAW files.

ypriverol added good first issue dia analysis release 1.3 labels

ypriverol linked a pull request

that will close this issue

Add dda id ci and fixed some bugs #373

Merged

11 tasks

ypriverol closed this as completed in #373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment