Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL Locales have problem #11729

Closed
Rahimimojtaba opened this issue Mar 24, 2021 · 5 comments
Closed

RTL Locales have problem #11729

Rahimimojtaba opened this issue Mar 24, 2021 · 5 comments

Comments

@Rahimimojtaba
Copy link

Describe the bug
When do change fallbackLocale and overrideLocale in settings.yml of HTML5 to some of RTL languages such as Arabic or Hebrew, on join time, the page objects still LTR. Not affected.

To Reproduce
Steps to reproduce the behavior:

  1. Go to usr/share/meteor/bundle/programs/server/assets/app/config/settings.yml
  2. Change fallbackLocale and overrideLocale to ar or he.
  3. Then do bbb-conf --restart
  4. Create a test room and join. Page still LTR.

Expected behavior
It should change to RTL and load language translations.

Actual behavior
Not change to LTR and load language translations.

BBB Version : 2.3 - Alpha 8
@antobinary
@ffdixon

@antobinary
Copy link
Member

Thanks @Rahimimojtaba
@ramonlsouza just fixed something similar via #11724 I will let him comment if this is a separate issue.
Thanks for reporting!

@antobinary antobinary added this to the Release 2.3 milestone Mar 24, 2021
@ramonlsouza
Copy link
Member

ramonlsouza commented Mar 24, 2021

Thanks @Rahimimojtaba
@ramonlsouza just fixed something similar via #11724 I will let him comment if this is a separate issue.
Thanks for reporting!

I was not able to reproduce the issue in develop branch, before and after changes made in #11724... Maybe it was fixed by another recent PR

@Rahimimojtaba
Copy link
Author

@antobinary Thanks for follow up.
@ramonlsouza I just did test on bigbluebutton online demo and same result. Upon joining, it's RTL and then move to LTR. Also some times in LTR mode, it show the RTL translates!
Maybe it's fixed in recent PRs.

@antobinary
Copy link
Member

I am not aware of recent PRs touching on LTR vs RTL mode.

@Rahimimojtaba could you please copy-paste the exact configs changes you made (this can help us reproduce locally and will accelerate the solution)

Is it

overrideLocale: ar
fallbackLocale: ar

@Rahimimojtaba
Copy link
Author

Fixed in Beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants