Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Poll) User/Presenter typed responses are always being translated #12546

Closed
germanocaumo opened this issue Jun 9, 2021 · 1 comment
Closed

Comments

@germanocaumo
Copy link
Collaborator

germanocaumo commented Jun 9, 2021

Describe the bug
As described by @schrd in #12534:

This leads me to another bug: Even answers entered in user response are translated (and should not). Example:

  1. Choose a locale != english
  2. start a poll with user responses
  3. enter "yes" as answer. It will be translated to the chosen locale. IMHO it should not be translated.

This also happens when the presenter manually enter a default answer in English (ex: yes/false),

Expected behavior
The answer should not be translated when the user/presenter type the answer.

Actual behavior
The answers are always being translated if the answers are written in english.

Additional context
This is easy to fix in the live result component and in the user polling component, we just need to check if the poll is not a default one (can check via isDefaultPoll from service).
But in the Whiteboard we do not have the poll type sent with the annotation so this would require adding the info in akka-apps.

@germanocaumo germanocaumo changed the title User/Presenter typed responses are always being translated (Poll) User/Presenter typed responses are always being translated Jun 9, 2021
@antobinary antobinary added this to the Release 2.3 milestone Jun 9, 2021
@antobinary
Copy link
Member

Fixed in #12561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants