Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: add a status code for the enter endepoint response. #16036

Closed
Tainan404 opened this issue Nov 21, 2022 · 1 comment
Closed

Refactor: add a status code for the enter endepoint response. #16036

Tainan404 opened this issue Nov 21, 2022 · 1 comment
Assignees
@gustavotrott
Labels
module: core

Comments

@Tainan404
Copy link
Member

Describe the bug
Currently if a request for the /enter fails it returns a returncode, containing the string failed and the message showing a generic message for the error. When it fails we assume the statuscode in the client, would be great it be decided in the server thar would allow the client threat it better depending the error.

bigbluebutton/bigbluebutton-web/grails-app/controllers/org/bigbluebutton/web/controllers/ApiController.groovy

Line 909 in 052fc41

returncode RESP_CODE_FAILED

Expected behavior
the client receives a status code and could do a good redirection in the client

Actual behavior
We receive a generic status saying if it failed or not
@Tainan404 Tainan404 mentioned this issue Nov 21, 2022
Merged
@gustavotrott gustavotrott self-assigned this Nov 21, 2022
@gustavotrott gustavotrott mentioned this issue Nov 24, 2022
Merged
@gustavotrott
Copy link
Collaborator

Improved in #16060 returning the new messageKey prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gustavotrott gustavotrott

Labels
module: core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gustavotrott @Tainan404