Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Lozenge to Badge and add tests & docs #118

Merged
merged 9 commits into from Aug 1, 2019
Merged

Update Lozenge to Badge and add tests & docs #118

merged 9 commits into from Aug 1, 2019

Conversation

amckemie
Copy link
Contributor

@amckemie amckemie commented Aug 1, 2019

What?

  • Change lozenge to badge
  • Remove primary variant
  • Add storybook documentation for badge
  • Add tests for badge

Why?

  • Design changed name to Badge to be clearer and more consistent with industry standard
  • Design removed blue as a possible color and state as it implies action to be taken.
  • Prep for beta

Testing

  • Ran jest tests

@deini
Copy link
Member

deini commented Aug 1, 2019

Left a few minor comments, but overall looks pretty good 💯

@deini deini merged commit 246a898 into bigcommerce:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanceaclark chanceaclark chanceaclark left review comments

@deini deini deini approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amckemie @deini @chanceaclark