-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG icons breaking icon-sprite.svg #1246
Comments
same issue |
@nowlena @xpothemes I'm having some trouble reproducing this. Could you give me a little more info on the theme version you're using and the exact steps you took when you saw the issue? Thanks! |
Thank you, @nowlena ! I'm seeing the issue now. I'll get a ticket in for this so we can address it. |
same issue |
same issue here too |
Still facing the same issue. Any solution? |
@techxlers the solution is in code review here #1258. Hopefully it should be merged in a day or 2. |
@junedkazi Thanks. BTW I am able to solve the issue by removing following "mask", "sketch:type", "sketch:name", "xlink". Icons are working now :) |
Same issue here. Tried implementing fix in #1258 but no luck |
@PeteyRev Did you try my fix? |
@techxlers I did except for the "remove xlink" - Where are you removing that, on the icon files themselves, or when you are adding to html:
|
@PeteyRev Go to assets/img/icon-sprite.svg file. Open that file in any editor and then find the words which I have mentioned in my previous comment and then simply delete those tags. |
@techxlers perfect, thanks! Had to delete the mask element from stumbleupon.svg and its working now |
For reference, my initial post here explains how to fix the issue:
|
@nowlena thanks, I think I may have overlooked that initially. Not enough coffee today |
Is this still an issue on the latest cornerstone ? |
@junedkazi this was an issue for me on version 2.1, so I think so |
This is still an issue in 2.2 This still works on 2.2
|
I am having this same issue on the latest version - is there any update on this? |
Expected behavior
When generating
icon-sprite.svg
viagrunt svgstore
the sprite should load properly.Actual behavior
The
svg.icons-svg-sprite
src gets set to(Unknown)
instead of the SVG sprite as intended.The reason:
icon-sprite.svg
cannot be loaded due toNamespace prefix sketch for type on path is not defined
I was able to fix the issue by stripping down (ie. removing the "mask" and " sketch:type" attributes) the following SVGs:
Steps to reproduce behavior
Nothing specific, when running the Theme this issue occurred both locally and when bundling then applying to a storefront.
The text was updated successfully, but these errors were encountered: