Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will exposing foundation break cornerstone? #2249

Open
fthobe opened this issue Aug 26, 2022 · 1 comment
Open

Will exposing foundation break cornerstone? #2249

fthobe opened this issue Aug 26, 2022 · 1 comment

Comments

@fthobe
Copy link

fthobe commented Aug 26, 2022

Hey @bookernath ,

Will including default html classes break cornerstone?

// Set these to true so that Foundation styles are exposed from Citadel
$include-html-classes: false !default;
$include-print-styles: false !default;
$include-html-global-classes: $include-html-classes !default;

@fthobe
Copy link
Author

fthobe commented Sep 19, 2022

Hey @bc-vlad-dlogush @bookernath , It would be really great to get a confirmation or denial if an exposure of the foundation classes should / would break cornerstone.

Given that updating custom cornerstone templates remains a pain it might be a consideration for customization to go with foundation leaving the original code in tact.

Please state your thoughts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant