Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazyload product videos - videos.html #1217

Closed
PeteyRev opened this issue May 2, 2018 · 3 comments
Closed

Lazyload product videos - videos.html #1217

PeteyRev opened this issue May 2, 2018 · 3 comments

Comments

@PeteyRev
Copy link
Contributor

PeteyRev commented May 2, 2018

Any reason why this is not being utilized?

            <iframe
                id="player"
                type="text/html"
                width="640"
                height="390"
                frameborder="0"
                webkitAllowFullScreen
                mozallowfullscreen
                allowFullScreen
                class="lazyload"
                data-src="//www.youtube.com/embed/{{this.featured.id}}"
                data-video-player>
            </iframe>

Id be happy to make a pull request, just wondering since the video thumbnails are being lazy loaded

@bookernath
Copy link
Contributor

PR welcome!

@PeteyRev
Copy link
Contributor Author

PeteyRev commented May 2, 2018

@bookernath Thanks, done

I also noticed a bigger issue that is fixed in the same PR, the video thumbnails when clicked aren't changing the main video

@junedkazi
Copy link
Contributor

Fixed in #1221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants