Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wishlist dropdown background color bleeding out of container #1283

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Fix wishlist dropdown background color bleeding out of container #1283

merged 1 commit into from
Jun 26, 2018

Conversation

sacr3dc0w
Copy link
Contributor

What?

The wishlist dropdown background color was bleeding out due to the right padding on the dropdown container. We can fix this by setting the background of the dropdown to transparent and setting a background color for the buttons, which are contained in the dropdown. Since the original value was white, and on Bold this cause white-on-white, lets set default background colors for each variant.

Tickets / Documentation

Screenshots

bold, before
bold 1 before 1
bold, before - hover
bold 1 before 2 - hover
bold, after
bold 2 after 1
bold, after - hover
bold 2 after 2 - hover
light, before
light 1 before 1
light, before - hover
light 1 before 2 - hover
light, after
light 2 after 1
light, after - hover
light 2 after 2 - hover
warm, before
warm 1 before 1
warm, before - hover
warm 1 before 2 - hover
warm, after
warm 2 after 1
warm, after - hover
warm 2 after 2 - hover
theme editor
ztheme editor

@bigbot
Copy link

bigbot commented Jun 22, 2018

Autotagging @bigcommerce/storefront-team @davidchin

@junedkazi junedkazi merged commit f67b549 into bigcommerce:master Jun 26, 2018
@sacr3dc0w sacr3dc0w deleted the wishlist-dropdown-fix branch June 26, 2018 18:19
@junedkazi junedkazi mentioned this pull request Jun 29, 2018
@bigmadness
Copy link

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants