Add option to disable arrows on the homepage carousel #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
|
This PR needs a rebase. |
|
@sacr3dc0w LGTM, Just one comment Please change capitalization to "Show carousel arrows". We can merge that after rebase |
junedkazi
reviewed
Oct 8, 2018
| @@ -907,6 +907,12 @@ | |||
| "force_reload": true, | |||
| "id": "homepage_show_carousel" | |||
| }, | |||
| { | |||
| "type": "checkbox", | |||
schema.json
Outdated
| @@ -907,6 +907,12 @@ | |||
| "force_reload": true, | |||
| "id": "homepage_show_carousel" | |||
| }, | |||
| { | |||
| "type": "checkbox", | |||
| "label": "Show Carousel Arrows", | |||
There was a problem hiding this comment.
Should have the capitalization changed to be Show carousel arrows, but looks good other than that.
ghost
closed this
ghost
reopened this
ghost
closed this
ghost
reopened this
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently if you want to hide/disable the arrows on the homepage carousel, you'll need to use either CSS or add JavaScript to the bundle. This PR adds an option to the theme editor.
Tickets / Documentation
Screenshots
True (Default)
False
Theme Editor