BIG-19104 Icons as SVG sprite via grunt #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
You can trash everything in these files besides the svg/path right? Or does the grunt task sort that out itself?
Edit: Looks like it does... Can probably disregard this comment. Is the <title> bit that gets outputted needed? Or is that just another byproduct of the process?
There was a problem hiding this comment.
See templates/components/common/icons/icon-defs.html for outputted svg.
This are just the individual svg icons you export from where ever. Just in case you need them...
|
LGTM 👍 |
bc-chris-roper
added a commit
that referenced
this pull request
Jul 1, 2015
BIG-19104 Icons as SVG sprite via grunt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to stencil for SVG sprites, to handle icons.
Grunt task
grunt svgstorewill take a folder of svg files (they still need to be clean svg exports, with no inlinefill:#hexsetting on the paths, I can't automate that.) and build a sprite.The sprite is placed in a handlebars template
templates/components/common/icons/icon-defs.html, which is loaded on base.html for every page to use.You can then call an icon anywhere on the page with
<svg><use xlink:href="#icon-facebook" /></svg>changing the#icon-nameOfSVGFileto your desired icon.Also brought in the icon component from Citadel, to remove a little boilerplate from the social links styles
@bc-miko-ademagic @christopher-hegre @bc-chris-roper @haubc