Show bulk discounts only if enabled through store settings. #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Cornerstone shows bulk discounts available on all products that have rules associated with them, regardless of the "Enable Bulk Discount?" setting in Display Settings in Store Settings > Display.
This is reliant on a change to expose
settings.bulk_discount_enabledto the Stencil context: https://github.com/bigcommerce/bigcommerce/pull/25352If Bulk Discounts are enabled, bulk discounts will show on product pages with bulk discount rules associated with them, as they do now.
If Bulk Discounts are disabled, bulk discounts will not show up, even if a product has a bulk discount rule applied to it.
Tickets / Documentation
Screenshots
Before
Product Without bulk discounts:
Product With bulk discounts, Bulk discounts Disabled:
Product With bulk discounts, Bulk discounts Enabled:
After
Product Without bulk discounts:
Product With bulk discounts, Bulk discounts Disabled:
Product With bulk discounts, Bulk discounts Enabled:
Warnings
If a theme with this change is somehow applied to a store without the Bigcommerce change that exposes
settings.bulk_discount_enabled, bulk pricing will not appear under any circumstances because the Handlebarsifis wrapped around that div.