fix(catalog): MERC-3743 Fix zoom behavior for small images in gallery #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
| @@ -2,6 +2,7 @@ import $ from 'jquery'; | |||
| import 'easyzoom'; | |||
| import _ from 'lodash'; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
nit: extra whitespace
christensenep
approved these changes
Aug 8, 2018
|
💚 . Please add before and after screenshots or GIFs to the description, as well as a Changelog entry under Draft. |
|
♻️ |
junedkazi
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixed issue with Cornerstone product image zoom functionality. If images were too small (less than 500px), zoomed image would not show properly.
Solution: Set up a checkImage() function to check image size before easyzoom-flyout. If image is less than image container (~500px), easyzoom-flyout is hidden, else, easyzoom functions normally.
Tickets / Documentation
Add links to any relevant tickets and documentation.
Images / Gifs
Previous Zoom Function (bug)
Image of bug
Gif of bug
Current Zoom Function (Fix)