fix(storefront): STRF-5282 Unable to add products to cart with 2 or more non-required File Upload options using Safari #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
bc-NikitaPuzanenko
force-pushed
the
STRF-5282
branch
from
507c4eb
to
435f387
Compare
lord2800
reviewed
Aug 27, 2018
| formData.delete(key); | ||
| const filteredFormData = new FormData(); | ||
| for (let i = 0; i < form.elements.length; i++) { | ||
| if (form.elements[i].type !== 'file' && form.elements[i].value && form.elements[i].name) { |
There was a problem hiding this comment.
This can be cleaned up a bit:
let element = form.elements[i];
if (element.type === 'file' && element.size > 0) {
filteredFormData.append(element.name, element.files[0], element.files[0].name);
} else if (element.name && element.value) {
filteredFormData.append(element.name, element.value);
}
bc-NikitaPuzanenko
force-pushed
the
STRF-5282
branch
from
435f387
to
8800171
Compare
lord2800
approved these changes
Sep 10, 2018
Ubersmake
suggested changes
Sep 12, 2018
bc-NikitaPuzanenko
force-pushed
the
STRF-5282
branch
from
8800171
to
b29d1f3
Compare
…ore non-required File Upload options using Safari
bc-NikitaPuzanenko
force-pushed
the
STRF-5282
branch
from
87b528e
to
ee23123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Safari only does one iteration in the current
for ofloop. This change will create a new FormData object and append valid entries using a standard for loop instead.Screenshots (if appropriate)
Before:
After:
