Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added hidden input with no value for a checkbox #1355

Merged
merged 1 commit into from Sep 24, 2018
Merged

added hidden input with no value for a checkbox #1355

merged 1 commit into from Sep 24, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 21, 2018 •
edited by ghost

What?

Added hidden input for checkbox to represent "No" for unchecked checkboxes.

Screenshots (if appropriate)

screen shot 2018-09-21 at 5 52 14 pm

screen shot 2018-09-21 at 5 52 04 pm

screen shot 2018-09-21 at 5 51 56 pm

screen shot 2018-09-21 at 5 51 49 pm

screen shot 2018-09-21 at 5 51 41 pm

@bigbot
Copy link

bigbot commented Sep 22, 2018

Autotagging @bigcommerce/storefront-team @davidchin

Ubersmake
Ubersmake approved these changes Sep 24, 2018
View reviewed changes
Copy link
Contributor

@Ubersmake Ubersmake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ubersmake Ubersmake merged commit 59aa20d into bigcommerce:master Sep 24, 2018
@Ubersmake Ubersmake mentioned this pull request Oct 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bigbot @Ubersmake