fix(storefront): STRF-5948 Cleanup and XSS fix on Cart page. #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
bookernath
approved these changes
Jan 25, 2019
bc-vandana
approved these changes
Jan 28, 2019
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Certain product options allow for user-submitted input, which in the case of JS can be executed on the Cart page. This value is now escaped properly on the Cart page. This is also addressed on the Returns page.
This also cleans up code related to Configurable Fields, which were removed in #1407.
This does not address Custom Fields, which are entirely determined by the merchant.
Tickets / Documentation