Resolve settings scope passed to components #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In various component includes, the store settings is incorrectly scoped. These changes correct the scope.
|
Autotagging @bigcommerce/storefront-team @davidchin |
|
This explains a bug we just discovered with data tags as well. cc @Ubersmake @bc-ranji @bc-krishsenthilraj |
junedkazi
suggested changes
Jan 31, 2019
There was a problem hiding this comment.
@mattcoy-arcticleaf the changes look good to me. Can you please add a changelog entry.
|
@junedkazi I have added a changelog entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
These changes correct the scope of the settings object in several files.
In this commit, the store settings object was improperly scoped using '../' unnecessarily in some instances. This causes defects in the quick view modal and poses risks for future development. Anything that can be toggled in the store settings does not appear in the quick view modal. This includes the product rating, social share links, and add to wish list button.
To replicate, go to the Cornerstone demo theme, and quick view any product.
Tickets / Documentation
N/A
Screenshots
Before:
After: