Updated Default Image path in theme config. #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
bookernath
approved these changes
Jan 31, 2019
junedkazi
reviewed
Feb 1, 2019
| "default_image_gift_certificate": "/assets/img/GiftCertificate.png", | ||
| "default_image_brand": "img/BrandDefault.gif", | ||
| "default_image_product": "img/ProductDefault.gif", | ||
| "default_image_gift_certificate": "img/GiftCertificate.png", |
There was a problem hiding this comment.
junedkazi
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled in #1397.
From the original PR:
What?
Fix for the Coming Soon product image on the Compare page. Instead of just fixing this on the compare page, this also changes the paths on the theme config.
Screenshots
Compare
Before
After
And for the sake of thoroughness and possible regressions:
Home Page
Before
After
Product Page
Before
After
Brands
Before
After
Gift Certificate at Cart
Before
After