fix(CP): ES-156 Fixed the filtering issues with price range filter selection #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
lord2800
reviewed
Apr 5, 2019
lord2800
reviewed
Apr 5, 2019
bc-krishsenthilraj
force-pushed
the
ES-156
branch
from
5a0fc1e
to
3864209
Compare
junedkazi
reviewed
Apr 5, 2019
junedkazi
reviewed
Apr 5, 2019
|
related #1232 |
bc-krishsenthilraj
force-pushed
the
ES-156
branch
from
3864209
to
315e380
Compare
bc-krishsenthilraj
force-pushed
the
ES-156
branch
from
315e380
to
fa81f32
Compare
|
💚 |
|
@bc-krishsenthilraj when I am looking at the 3rd screenshot I see 3 brands (38, 39, 40) in the url but only 2 brands selected. Shouldn't the url be updated ? |
junedkazi
approved these changes
Apr 10, 2019
|
This may also be a fix for #1367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Product filtering Price Filter clears other filters below it (or after in the query URL).
Tickets / Documentation
https://jira.bigcommerce.com/browse/ES-156
Screenshots (if appropriate)
Note:Please verify the URL params with selected Facets in each below image.Image 1: Resultant Products with all 3 brands and price range with 10-55 and
Field01with 3 colors.Image 2: Resultant Products with 3 brands and price range with 20-50 and
Field01with 3 colors.Image 3: Now only with 2 brands and price range with 20-40 and
Field01with 3 colors. But, due to the price range filter only 2 colors products are displayed.@bigcommerce/cp-dt