MERC-4842 Add additional regions #1491
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
kchu93
force-pushed
the
MERC-4842
branch
2 times, most recently
from
045206e
to
38cfbfc
Compare
|
@kchu93 did you include removing the snippets or that was done as part of a separate PR? |
kchu93
force-pushed
the
MERC-4842
branch
3 times, most recently
from
2d76ee1
to
dcce76a
Compare
|
@bookernath @BC-EChristensen So for this PR we have removed the |
| <div class="navPages-container" id="menu" data-menu> | ||
| {{> components/common/navigation-menu}} | ||
| </div> | ||
| </header> | ||
| {{{region name="header_bottom"}}} |
There was a problem hiding this comment.
If this is header bottom shouldn't this be inside the header tag ?
There was a problem hiding this comment.
So i spoke with @pedelman / @BC-EChristensen and i believe they wanted to move this outside of the header tag due to its placement. I can move this back if necessary, but they may be able to speak on this as well!
There was a problem hiding this comment.
I don't want you to move ... I am just trying to understand the naming and the reasoning behind it.
There was a problem hiding this comment.
Unfortunately we already have two regions, header_bottom and product_below_price, using two different naming schemes. We opted to adopt the second, but unfortunately we can't change this one.
You're right about menu_bottom below, though, we're changing that to home_below_menu
| @@ -21,6 +21,7 @@ | |||
| </div> | |||
| {{/if}} | |||
| <h1 class="page-heading">{{brand.name}}</h1> | |||
| {{{region name="brand_below_header"}}} | |||
There was a problem hiding this comment.
Can you please explain to me the logic behind when to use bottom and when to use below ?
There was a problem hiding this comment.
Hey Juned, similar to what Erik was stating above, but I believe we opted for below / 'above' as it would specify more so where a region would be.
| @@ -12,9 +12,11 @@ | |||
| limit: {{theme_settings.homepage_blog_posts_count}} | |||
| --- | |||
| {{#partial "hero"}} | |||
| {{{region name="home_below_menu"}}} | |||
There was a problem hiding this comment.
Changed menu_bottom to home_below_menu
|
@junedkazi Kevin made some changes to the naming to be more consistent. We can't change |
What?
Enable the following regions in cornerstone for enabling adding new content via widgets onto these pages:
(1) Homepage
(2) Brand
(3) Brands
(4) Category
(5) Product Page
(6) Search Page
Tickets / Documentation
MERC-4842