STRF-5521 PDP Product Reviews Link Not Clickable #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
bc-williamkwon
changed the title
|
Will it also support the use case when some one tries to hit a url with the anchor in it ? Example http://example.com/productpage/#product-reviews |
|
Yes, it does. It moves the page down to the reviews just as if it was show_product_reviews_tab:false |
megdesko
approved these changes
May 17, 2019
|
@bc-williamkwon Can you update the changelog as well? |
|
updated |
|
@bc-williamkwon Please squash your commits |
Update changelog.md for pr 1498 Made fix to product reviews link
|
Rebased and squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Previously when config.json had show_product_reviews_tab as true the reviews link when clicked would do nothing. This fix should make it so that instead the reviews tab is opened and window is directed to it.
Tickets / Documentation
https://jira.bigcommerce.com/browse/STRF-5521