Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up share.html conditional logic #1522

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Clean up share.html conditional logic #1522

merged 1 commit into from
Jun 13, 2019

Conversation

sacr3dc0w
Copy link
Contributor

@sacr3dc0w sacr3dc0w commented Jun 13, 2019 •
edited
Loading

What?

This should be else if as this is basically a switch statement.

Similar reason for logic cleanup in #1512.

@bigbot
Copy link

bigbot commented Jun 13, 2019

Autotagging @bigcommerce/storefront-team @davidchin

@bookernath
Copy link
Contributor

Thanks!

@bookernath bookernath merged commit 81205d3 into bigcommerce:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bookernath bookernath bookernath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sacr3dc0w @bigbot @bookernath