Remove ‘aria-hidden’ attribute from main menu #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bookernath
approved these changes
Aug 15, 2019
|
Autotagging @bigcommerce/storefront-team @davidchin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently, the aria-hidden attribute is being added to the main menu (id="menu") with a value of true. This breaks screen-reader capabilities as it hides the entire menu from the accessibility tree.
Additionally, this attribute is unneeded and redundant in this instance because the menu is being hidden with CSS (display: none). This also goes against MDN best practices for the attribute (see link below). Having the menu hidden with CSS is sufficient for hiding it from the accessibility tree.
This Pull Request removes the code that toggles the aria-hidden attribute on the menu (and sets it to true on page load).
Tickets / Documentation
Screenshots
Current code for menu element on page load
Updated code for menu element on page load