Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade core-js to version 3 #1598

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Conversation

jbruni
Copy link
Contributor

@jbruni jbruni commented Nov 15, 2019

What?

Reasons to upgrade to core-js version 3 are many, mainly the improved Babel integration.

In our case, we had a theme failing on Internet Explorer 11, and it boiled down to the fact that core-js version 2 does not provide polyfill for NodeList.forEach method. Version 3 of core-js provides this polyfill.

If only Cornerstone was using core-js version 3 out of the box, we would not have ran into that issue.

Tickets / Documentation

Screenshots (if appropriate)

⬇️ Comparison from core-js's README for v2 and v3:

core-js-idc


⬇️ Although NodeList usage is properly detected, core-js version 2 is missing polyfills for IE 11.

babel-preset-env-debug

Copy link
Contributor

@bookernath bookernath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for your contribution and very detailed justification!

Note: we won't cut a release of Cornerstone over the holiday selling season (Black Friday), so this release will be cut in December.

@oggede
Copy link

oggede commented Jan 4, 2020

Looks good. Thanks for your contribution and very detailed justification!

Note: we won't cut a release of Cornerstone over the holiday selling season (Black Friday), so this release will be cut in December.

Can you please merge this update ASAP. I've been waiting over 1 month for it to update, as the error causes people to not be able to order on my website. The holiday season is over. Should be able to merge this. Thanks.

@bookernath
Copy link
Contributor

Hi @oggede ,

As this change is already merged to master, you can take advantage of it immediately by simply using the latest code in your custom theme.

However, our release for 4.3.1 containing this change was cut last week, and should be available as an update to the base Cornerstone theme in your control panel this week.

Hope this helps!

@bookernath
Copy link
Contributor

This update is now available for all stores.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants