Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): ES-721 fixed the issue for price filter collapse CP settings #1633

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

bc-krishsenthilraj
Copy link
Contributor

What?

Price filter always displays in expanded mode ignoring CP Setting. With this fix, Price filter honors the CP settings.

Tickets / Documentation

Screenshots (if appropriate)

Case 1: Expanded
image

image

Case 2: Collapsed
image

image

@bigbot
Copy link

bigbot commented Feb 7, 2020

Autotagging @bigcommerce/storefront-team @davidchin

Copy link
Contributor

@lord2800 lord2800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @bigcommerce/storefront-team

@kvnwang
Copy link
Contributor

kvnwang commented Feb 7, 2020

💚 Price filters collapsed when applied

Screen Shot 2020-02-07 at 10 56 08 AM

Screen Shot 2020-02-07 at 10 54 08 AM

@bookernath bookernath merged commit 3492c08 into bigcommerce:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants