feat(search): ES-466 Facets with & symbol works now #1654
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
There was a problem hiding this comment.
cc @bigcommerce/storefront-team (code in general) and @bigcommerce/security (to verify that there's no injectable parts for product option and custom field values)
We did some testing to ensure it doesn't allow injection, but we didn't go in depth. I'm pretty sure it works, I'd just like independent confirmation.
| @@ -3,7 +3,7 @@ | |||
| <div | |||
| class="accordion-navigation toggleLink {{#unless ../start_collapsed }} is-open {{/unless}}" | |||
| role="button" | |||
| data-collapsible="#facetedSearch-content--{{hyphenate facet }}"> | |||
| data-collapsible="#facetedSearch-content--{{#replace '&' (hyphenate facet) }}{{/replace}}"> | |||
There was a problem hiding this comment.
I really don't like the idea of doing special characters replaces at the handlebars level. Today we are doing & tomorrow it is going to be some other special characters.
We should either strip it or escape it at the backend level. Right now
There was a problem hiding this comment.
You can't escape & to be placed in a fragment. There are no other special characters like this.
There was a problem hiding this comment.
Since we are just doing a replace for & in the string for the fragment can't we do that on the backend itself ?
There was a problem hiding this comment.
We don't have two variables we can key this on, unfortunately.
|
Tested on staging by uploading and applying theme from the ticket
Looks good 💚 |
What?
Faceted search filters that include ampersand (&) breaks 'Show More' links.
With this fix, now we can have Facets with
&symbol andShow Morelink works fine.Tickets / Documentation
Testing Steps:
Custom Field(with same name like _ Custom & Color _) and with different values for each product and save the Products.showto 5 items and saveShow Morelink for this new filter and the popup window shows all the filter values.Screenshots (if appropriate)
List of all Facets:
Facet with
&in the name & valueShow Morelink displays the popup with filterable valuesOther Facet's
Show Morelink works fine too..@bigcommerce/artemis-dt @lord2800 @kwang30