fix(Storefront): BCTHEME-3 Horizontal scrolling on some resolutions #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
|
@yurytut1993 can you please attach some before and after screenshots |
|
@junedkazi here are In the task we have also videos with bug and fix this issue |
junedkazi
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
@junedkazi
Horizontal scrolling on some resolutions, for example, on iPad.
When social links in the footer turned on and they aligned to the right, unnecessary horizontal scroll appears. It was so because of position styles of social links block (was shifted to the right) and his width.
Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
Attach images or add image links here.