fix(Cornerstone): BCTHEME-2 Sale badge "Burst" does not change colour on hover #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golcinho
reviewed
Jul 3, 2020
… on hover (updates after comments)
|
Autotagging @bigcommerce/storefront-team @davidchin |
golcinho
approved these changes
Jul 6, 2020
|
@yurytut1993 the changes look sane. Can you please attach some screenshots to show before and after. |
@junedkazi in the ticket you can see 2 videos with bug and fix |
junedkazi
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Cornerstone has 3 types of sale badge - sash, topleft and burst. On hover product with sale badge it must change color that user can setup in storefront panel (color_hover_product_sale_badges settings option in config.json). sash & topleft affecting this value, but burst not. I have added styles for burst sale badge and now hover works on all sale badges
@BC-tymurbiedukhin @golcinho @junedkazi
Tickets / Documentation
Ticket