feature(bctheme): BCTHEME-56 Long Product Descriptions Cause Large White Space Under Product Image #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite Space Under Product Image
|
Autotagging @bigcommerce/storefront-team @davidchin |
golcinho
approved these changes
Jul 14, 2020
|
@junedkazi Yes, we're going to make this consistent at all screen widths |
junedkazi
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
To avoid space on the left side of the screen when we have a huge description on a product, as suggested in the task, I made description block on the whole screen. So I just removed styles that make this block on the half of the screen width on large displays
Tickets / Documentation
Ticket
Screenshots (if appropriate)
before
after
