fix(storefront:)STRF-8521 add correct alt text on image change in product view #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
yurytut1993
reviewed
Jul 28, 2020
Comment on lines
45
to
52
| const first = 0; | ||
| const $target = $(e.currentTarget); | ||
| const imgObj = { | ||
| mainImageUrl: $target.attr('data-image-gallery-new-image-url'), | ||
| zoomImageUrl: $target.attr('data-image-gallery-zoom-image-url'), | ||
| mainImageSrcset: $target.attr('data-image-gallery-new-image-srcset'), | ||
| $selectedThumb: $target, | ||
| mainImageAlt: $target[first].children[first].alt, | ||
| }; |
There was a problem hiding this comment.
I suppose that variable on line 45 is unnecessary here, because it has no calculation and no specific usage
BC-tymurbiedukhin
approved these changes
Jul 28, 2020
yurytut1993
approved these changes
Jul 28, 2020
bc-alexsaiannyi
force-pushed
the
STRF-8521
branch
from
c579431
to
90f377f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
@BC-tymurbiedukhin @yurytut1993
This PR fixes issue with viewing a product with multiple images. When User clicks on other available images the alt text doesn't change and continues to display a text for the default image.
Tickets / Documentation
Screenshots (if appropriate)
Alt Text Images Fixed