feature(storefront): BCTHEME-196 Create unified focus styling in Cornerstone #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
BC-tymurbiedukhin
approved these changes
Sep 1, 2020
yurytut1993
force-pushed
the
BCTHEME-196
branch
from
3a0222d
to
e699602
Compare
bc-alexsaiannyi
approved these changes
Sep 1, 2020
yurytut1993
force-pushed
the
BCTHEME-196
branch
from
c7f469e
to
56148d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixed next group of issues:
https://jira.bigcommerce.com/browse/BCTHEME-177
https://jira.bigcommerce.com/browse/BCTHEME-180
https://jira.bigcommerce.com/browse/BCTHEME-181
https://jira.bigcommerce.com/browse/BCTHEME-183
https://jira.bigcommerce.com/browse/BCTHEME-182
I took Chrome focus styles as a base and changed it outline color for it to be acceptable for light and dark themes.
We can use this focus styles as a base and rewrite it for custom cases if we will need
Tickets / Documentation
Ticket
Screenshots (if appropriate)
light theme contrast
dark theme contrast
carousel arrows focus
carousel dots focus
cart buttons focus
options focus
