Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce lodash usage in compare-products.js and image-gallery.js #1827

Merged
merged 1 commit into from Oct 28, 2020
Merged

Reduce lodash usage in compare-products.js and image-gallery.js #1827

merged 1 commit into from Oct 28, 2020

Conversation

sacr3dc0w
Copy link
Contributor

@sacr3dc0w sacr3dc0w commented Sep 8, 2020 •
edited

What?

Reduce lodash usage (and bundle size) by utilizing the object spread operator to clone imgObj in image-gallery.js when setMainImage() runs.

@bigbot
Copy link

bigbot commented Sep 8, 2020

Autotagging @bigcommerce/storefront-team @davidchin

@bigbot
Copy link

bigbot commented Oct 21, 2020

Autotagging @bigcommerce/themes-team

junedkazi
junedkazi approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can drop it completely it will be huge. One small step in the right direction.

@BC-tymurbiedukhin
Copy link
Contributor

Should themes team take attention on replacing lodash utils with custom helpers?

@sacr3dc0w sacr3dc0w changed the title PDP: Reduce lodash usage by utilizing object spread operator to set main image Reduce lodash usage Oct 22, 2020
@sacr3dc0w
Copy link
Contributor Author

sacr3dc0w commented Oct 22, 2020 •
edited

I was removing _.map() in an internal module we use and figured I'd replace it here as well.

@sacr3dc0w sacr3dc0w changed the title Reduce lodash usage Reduce lodash usage in compare-products.js and image-gallery.js Oct 22, 2020
@bookernath bookernath merged commit 18ce009 into bigcommerce:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junedkazi junedkazi junedkazi approved these changes

@bookernath bookernath bookernath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sacr3dc0w @bigbot @BC-tymurbiedukhin @junedkazi @bookernath