Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bctheme): BCTHEME-1103 Add lang attribute to html tag in checkout #2210

Merged
merged 1 commit into from May 25, 2022
Merged

Conversation

huntario
Copy link
Collaborator

@huntario huntario commented May 11, 2022

What?

"The LANG tag (i.e. the lang="" attribute) is designed to signal screen readers pronunciation engines to switch to another language. For this reason [ tagging Web text as being in a particular language is required in WCAG 2.0 ]"(https://accessibility.psu.edu/foreignlanguages/langtaghtml/ )

Requirements

  • ✅ CHANGELOG.md entry added (required for code changes only)

Tickets / Documentation

Add links to any relevant tickets and documentation.

Screenshots (if appropriate)

Screen Shot 2022-05-11 at 6 07 16 PM

Screen Shot 2022-05-11 at 5 30 02 PM

@huntario huntario marked this pull request as ready for review May 11, 2022 23:09
@huntario huntario changed the title feat(bctheme): Add lang attribute to html tag in checkout feat(bctheme): BCTHEME-1103 Add lang attribute to html tag in checkout May 21, 2022
@BC-krasnoshapka BC-krasnoshapka merged commit 1150f08 into bigcommerce:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants