Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(orders) ORDERS-4645 Add pickups to storefront order invoice #2216

Merged
merged 3 commits into from Jun 16, 2022
Merged

feat(orders) ORDERS-4645 Add pickups to storefront order invoice #2216

merged 3 commits into from Jun 16, 2022

Conversation

WillemHoman
Copy link
Contributor

@WillemHoman WillemHoman commented May 25, 2022 •
edited

What?

Add pickups to storefront invoice

Requirements

  • CHANGELOG.md entry added (required for code changes only)

Tickets / Documentation

ORDERS-4645

bc-app PR

Screenshots

Digital only order

Screen Shot 2022-05-26 at 9 57 19 am

Shipping Single Address

Screen Shot 2022-05-26 at 9 56 46 am

Pickup Single Address

Screen Shot 2022-05-26 at 11 04 55 am

Mixed consignment with multiple Shipping addresses

Screen Shot 2022-05-26 at 9 55 52 am

ping @bigcommerce/orders @bigcommerce/themes-team

@WillemHoman WillemHoman force-pushed the ORDERS-4645-storefront-invoice branch from d9d37b4 to 5008be6 Compare May 26, 2022 00:13
@WillemHoman WillemHoman marked this pull request as ready for review May 26, 2022 00:16
donald-nguyen-bc
donald-nguyen-bc approved these changes May 26, 2022
View reviewed changes
Copy link

@donald-nguyen-bc donald-nguyen-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Well done Willem, I will steal this design into the CP invoice template 😄

@bc-munjal
Copy link
Contributor

🙇 nicely done!!

@BC-krasnoshapka BC-krasnoshapka self-requested a review May 27, 2022 12:11
BC-krasnoshapka
BC-krasnoshapka reviewed May 27, 2022
View reviewed changes
Copy link
Contributor

@BC-krasnoshapka BC-krasnoshapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WillemHoman please don't forget to update CHANGELOG.md

@WillemHoman WillemHoman force-pushed the ORDERS-4645-storefront-invoice branch 3 times, most recently from b22dd9e to 1275d77 Compare May 31, 2022 06:38
@WillemHoman
Copy link
Contributor Author

@WillemHoman please don't forget to update CHANGELOG.md

@BC-krasnoshapka thanks for the reminder, is this correct? Should it be in the draft section? 1275d77

@BC-krasnoshapka
Copy link
Contributor

@WillemHoman yes, correct. thanks

@WillemHoman
Copy link
Contributor Author

WillemHoman commented May 31, 2022 •
edited

@BC-krasnoshapka what is the process for getting this approved, merged and released?
I don't yet have an approval from themes team and don't seem to have write access to this repo.
Does someone from themes team need to then cut a release?

@BC-krasnoshapka BC-krasnoshapka requested a review from a team June 1, 2022 08:43
@BC-krasnoshapka
Copy link
Contributor

@WillemHoman themes team will review this. Next regular Cornerstone release is planned on 29th of June.

@WillemHoman
Copy link
Contributor Author

@bc-yevhenii-buliuk @bc-vlad-dlogush could I please get a review on this

@WillemHoman WillemHoman force-pushed the ORDERS-4645-storefront-invoice branch from 1275d77 to c3f0384 Compare June 15, 2022 23:21
@WillemHoman
Copy link
Contributor Author

@BC-krasnoshapka @bc-vlad-dlogush @bc-yevhenii-buliuk
How do I get this merged?
It has been in code review for 3 weeks now and I just had to resolve a conflict.

@BC-krasnoshapka BC-krasnoshapka merged commit b46e62e into bigcommerce:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bc-vincent-zhao bc-vincent-zhao bc-vincent-zhao approved these changes

@donald-nguyen-bc donald-nguyen-bc donald-nguyen-bc approved these changes

@bc-vlad-dlogush bc-vlad-dlogush bc-vlad-dlogush approved these changes

@BC-krasnoshapka BC-krasnoshapka BC-krasnoshapka approved these changes

@bc-munjal bc-munjal bc-munjal approved these changes

@bc-yevhenii-buliuk bc-yevhenii-buliuk Awaiting requested review from bc-yevhenii-buliuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@WillemHoman @bc-munjal @BC-krasnoshapka @bc-vincent-zhao @donald-nguyen-bc @bc-vlad-dlogush