feat(payment): ADYEN-314 vaulting lib initialization #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitalii-koshovyi
force-pushed
the
ADYEN-314
branch
from
d5be061
to
001aea2
Compare
vitalii-koshovyi
changed the title
vitalii-koshovyi
force-pushed
the
ADYEN-314
branch
from
b890a8e
to
f31d09b
Compare
|
Hi @vitalii-koshovyi, looks good in general but have few questions.
|
vitalii-koshovyi
force-pushed
the
ADYEN-314
branch
from
f31d09b
to
dd2d673
Compare
vitalii-koshovyi
force-pushed
the
ADYEN-314
branch
from
dd2d673
to
b92bea4
Compare
|
@bc-alexsaiannyi Theme doesn't load storefront-account-payments library when experiment is off and still renders default vaulting form. |
bc-alexsaiannyi
approved these changes
Dec 14, 2022
BC-krasnoshapka
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Initialization of storefront-account-payments when experiment is on.
It initializes storefront-account-payments library when experiment is on, when experiment is off it renders default vaulting form.
bcapp PR
library pr
Requirements
Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
Screen.Recording.2022-11-28.at.14.19.24.mov