Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

AKT Bug #39

Open
weizhehuang0827 opened this issue Jul 17, 2023 · 0 comments
Open

AKT Bug #39

weizhehuang0827 opened this issue Jul 17, 2023 · 0 comments

Comments

@weizhehuang0827
Copy link
Collaborator

馃悰 Description

https://github.com/bigdata-ustc/EduKTM/blob/main/EduKTM/AKT/AKTNet.py#L273
The mask_fill operation on this line should be replaced with mask_fill_, otherwise it will cause data leakage

What have you tried to solve it?

origin
scores.masked_fill(mask == 0, -1e32)
solution
scores.masked_fill_(mask == 0, -1e32)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant