Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto pep8 the code #79

Closed
beckermr opened this issue Mar 8, 2017 · 3 comments
Closed

Auto pep8 the code #79

beckermr opened this issue Mar 8, 2017 · 3 comments

Comments

@beckermr
Copy link
Collaborator

beckermr commented Mar 8, 2017

I hate myself for saying this, but a lot people expect pep8 looking code. Biggles is def not very pep8 ish. I am ok with 120 character lines.

@esheldon
Copy link
Collaborator

esheldon commented Mar 8, 2017

I think the biggest issue I have is the opaqueness. The code is highly general, which is good if you already know how it works, but since I don't a lot of it seems like magic. Maybe as part of the style effort we could make some of the data structures more transparent.

@esheldon esheldon closed this as completed Mar 8, 2017
@esheldon esheldon reopened this Mar 8, 2017
@beckermr
Copy link
Collaborator Author

beckermr commented Mar 8, 2017

Looks like your message was cutoff. I agree. The objects are quite opaque. Docs would help, but the layered inheritance structure hides methods.

@beckermr
Copy link
Collaborator Author

beckermr commented Mar 8, 2017

This issue is related to #19. I will make a separate issue for cleaning up the object structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants