Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 glitches/problems #42

Closed
pilluli opened this issue Oct 12, 2011 · 8 comments
Closed

2 glitches/problems #42

pilluli opened this issue Oct 12, 2011 · 8 comments

Comments

@pilluli
Copy link
Contributor

pilluli commented Oct 12, 2011

Hi BigNoid,

I've found two problems in the new versions of the skin. Here is the small list (let me know if you want me to edit this and create an issue for each one of them).

  1. Recently added movies widget does not get focus. I am using the menus at the bottom and when I press the up button the widget does not get focus (it does with the recently added tvshows though)
  2. xbmc hangs when I try to go to the skin settings, home screen options. The new window appears but I can not move within it or go back. I am using the latest (as of today) eden sources.

Thanks yet again for a great skin!

@BigNoid
Copy link
Owner

BigNoid commented Oct 12, 2011

I could reproduce and fix the first one, but not the second one. Mind checking your 720p folder for the custom dialogs. There should be no other custom dialogs then the ones with format custom_XXXX_NAMEOFDIALOG.xml
If there are other it might explain the crash as xbmc tries to open 2 xml's with the same id. This could be caused by recent renaming of custom xmls I did.

@pilluli
Copy link
Contributor Author

pilluli commented Oct 12, 2011

Hi BigNoid,

Thanks for the help, the problem wasn't a custom dialog file but I thought that maybe an "old" settings was the problem. I deleted my guisettings.xml in my userdata folder and everything was ok (just had to re-enter my settings again). So the 2 problem is indeed fixed.

Regards!

@BigNoid BigNoid closed this as completed Oct 12, 2011
@pilluli
Copy link
Contributor Author

pilluli commented Oct 13, 2011

Sorry BigNoid to reply to this...

I did solve myself the second problem but for me the first one is still not fixed. I pushed your latest changes but I am still unable to navigate to latest movies added from the menu pressing the up arrow.

PS: I tried to change it myself in the code but to be honest I am lost in all the navigation code and all the conditions.. :(

@BigNoid
Copy link
Owner

BigNoid commented Oct 13, 2011

You're right. I must have made a typo after testing it. Could you check if it is fixed now.
a138e9f
should fix it.

@pilluli
Copy link
Contributor Author

pilluli commented Oct 13, 2011

It is definitely fixed now.. thanks!!

@pilluli
Copy link
Contributor Author

pilluli commented Oct 15, 2011

Sorry BigNoid but I think commit c441c4b broke the navigation again to get to the latest movies widget from a lower home menu.

Again, tried to solve it myself but this conditional code is a nightmare to follow :D

@BigNoid
Copy link
Owner

BigNoid commented Oct 15, 2011

5c102b6 should fix it. I tried to simplify the code a bit, but there are so many things to consider, widgets on/off, music playing video playing. It's hard to keep track of sometimes.

@pilluli
Copy link
Contributor Author

pilluli commented Oct 15, 2011

That indeed fixed it. Many thanks BigNoid and sure I understand these kind of small problems!! I am just grateful you make this beautiful skin and share it. I will keep bugging you with problems if I find them!! :D

The thing is that I don't really understand these conditionals and groups id's in the home window so it is difficult for me to fix them and send you a pull request so thanks again!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants