Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tables still using tableModule rather than TableModule #243

Closed
ivokwee opened this issue Mar 17, 2023 · 3 comments
Closed

Some tables still using tableModule rather than TableModule #243

ivokwee opened this issue Mar 17, 2023 · 3 comments
Assignees

Comments

@ivokwee
Copy link
Member

ivokwee commented Mar 17, 2023

Some tables still using tableModule (ui-PlotModule.R) rather than TableModule (ui-PlotModule2.R). Need update to TableModule and deprecate tableModule.

@ncullen93
Copy link
Contributor

ncullen93 commented Mar 22, 2023

There are six tables still using the old tableModule:

  • clustannot_table_module
  • datatable_timings
  • datatable_objectdims
  • datatable_objectsize
  • ctGeneTable_module
  • ctGseaTable_module

@ESCRI11 ESCRI11 self-assigned this Mar 22, 2023
@ncullen93
Copy link
Contributor

Looks like there was a ton of left-over or unused code in intersection_server.R from when things were converted to the newer TableModule and PlotModule. That included two tableModule instances (referenced above - ctGeneTable_module and ctGseaTable_module). I've gone ahead and removed them.

@ivokwee you can check it out here b86b7ff to see if this is some code that should be put back in somehow or if those tables/plots have actually just been reimplemented and someone forgot to delete this old version

@ncullen93
Copy link
Contributor

And with #358 there are officially no more tableModule references. I have also removed the function definition of tableModule to make its future use impossible. Let's circle back about ctGeneTable and ctGseaTable in a separate issue if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants