-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call .initialize from constructor #10
Comments
@Swaagie there could be some other flag to check im sure right? some post initializing that could be done for those cases? |
sure but a developer could potentially include logic in |
On a broader scope, functions like
|
Another thought, provide a plugin that adds standalone functionality to pagelets, that should keep the code clean and lean. Per example, rendering child pagelets is also an issue. Calling |
Why would optimize need to be called each time a pagelet is called outside of bigpipe? It only needs to be called once. And i'm +1 on adding a .standone method |
with each time I ment, each time any pagelet is used outside bigpipe. In stead of just calling |
Calling
initialize
by default (if available) would be a nice feature for standalone usability. It would also bring it closer in line with BackboneJS. The only problem is BigPipe currently relies on not callinginitialize
if the Pagelet is not authorized or disabled, see https://github.com/bigpipe/bigpipe/blob/master/page.js#L286-L290The text was updated successfully, but these errors were encountered: