Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CODE] optimize BloomAttention, remove unnecessary host-to-device transfers #1

Closed
justheuristic opened this issue Jun 12, 2022 · 2 comments
Labels
bug Something isn't working development

Comments

@justheuristic
Copy link
Collaborator

justheuristic commented Jun 12, 2022

TL;DR the current code for BloomAttention is surprisingly inefficient, with obvious problems that should be easy to fix

The current code for BloomAttention is surprisingly inefficient:

It also misses a ton of opportunities for in-place ops for memory savings, but that's the least of its problems

@justheuristic justheuristic changed the title optimize BloomAttention [CODE] optimize BloomAttention Jun 12, 2022
@justheuristic justheuristic added bug Something isn't working development labels Jun 12, 2022
@justheuristic justheuristic changed the title [CODE] optimize BloomAttention [CODE] optimize BloomAttention, remove unnecessary host-to-device transfers Jun 12, 2022
@justheuristic
Copy link
Collaborator Author

justheuristic commented Jun 19, 2022

@justheuristic
Copy link
Collaborator Author

I've copy-pasted changes from @younesbelkada 's PR above.
As of right now ( aaaf0c2 ) , all four issues are solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working development
Projects
None yet
Development

No branches or pull requests

1 participant