Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE11 incompatibilities #2408

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Fix IE11 incompatibilities #2408

merged 1 commit into from
Mar 21, 2024

Conversation

Telroshan
Copy link
Collaborator

@Telroshan Telroshan commented Mar 17, 2024

Description

Fixes some IE11 incompatibilities

  • default parameter value in function makeTagRegEx(tag, global = false), not supported by IE11
  • string literals in that same function, not supported by IE11 either
  • the test utility functions call htmx.processNode on text nodes (i.e. not actual Elements). This fails gracefully on modern browsers but not so gracefully on IE11. Added 2 checks in hx-on processing functions, to avoid calling undefined references (a text node doesn't have .attributes neither getElementsByTagName)
  • some tests cannot work on IE11 (unsupported features) but were simply not skipped, fixed that

Corresponding issue:

Testing

See #1687 with the procedure to run tests on IE11

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@Telroshan Telroshan added the bug Something isn't working label Mar 17, 2024
@1cg 1cg merged commit e64238d into bigskysoftware:dev Mar 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants