Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Retry requests #551

Open
chendo opened this issue Jul 12, 2021 · 6 comments
Open

Feature Request: Retry requests #551

chendo opened this issue Jul 12, 2021 · 6 comments

Comments

@chendo
Copy link

chendo commented Jul 12, 2021

We're seeing a lot of UnhandledRejection: Non-Error promise rejection captured with value: undefined errors when using hx-get in Safari, specifically mostly Mobile Safari. We suspect this to be network issues. It would be great if we could implement some kind of retry logic to minimise disruption to users.

@1cg
Copy link
Contributor

1cg commented Jul 13, 2021

what trigger are you using?

@chendo
Copy link
Author

chendo commented Jul 13, 2021

The trigger for this one is load delay:1s

@1cg
Copy link
Contributor

1cg commented Jul 13, 2021

maybe related to this: vuejs/vue-router#2881

@chendo
Copy link
Author

chendo commented Jul 13, 2021

I think that would explain the empty stack trace and we are using Sentry. However, the breadcrumbs before the error indicates sendError, so it would be still useful to be able to implement a retry mechanism.

image

@chendo
Copy link
Author

chendo commented Jul 14, 2021

Further trying to dig into this issue is complicated by the fact that htmx does not appear to pass on the raw error raised by xhr.onerror()

@1cg
Copy link
Contributor

1cg commented Jul 14, 2021

We can pass that through pretty easily, as well as a closure to invoke. Let me take a look at it today and circle back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants