Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] TFT no more able to connect to Marlin #2255

Closed
digant73 opened this issue Nov 18, 2021 · 19 comments · Fixed by #2241
Closed

[BUG] TFT no more able to connect to Marlin #2255

digant73 opened this issue Nov 18, 2021 · 19 comments · Fixed by #2241
Labels
bug Something isn't working

Comments

@digant73
Copy link
Contributor

digant73 commented Nov 18, 2021

Just to avoid panic, last merged PR #2250 made the TFT not able to connect to mainboard at startup for any fw different than RepRap.
The issue is already fixed by PR #2241

@oldman4U
Copy link
Contributor

I always wanted to write you this once.

Please help the community and close the ticket once you do not need it anymore. Thank you

🤗

@pfn
Copy link
Contributor

pfn commented Nov 22, 2021

That's interesting, checksums should still work on non-RRF firmwares. I wonder why not... maybe it's the missing line-number reset. I guess this will have to be a specific config.ini option, sadly :(

@xPew
Copy link
Contributor

xPew commented Nov 22, 2021

That's interesting, checksums should still work on non-RRF firmwares. I wonder why not... maybe it's the missing line-number reset. I guess this will have to be a specific config.ini option, sadly :(

Well, for now there is nothing specific in rrf config.ini so there is place for it… :D

@digant73
Copy link
Contributor Author

digant73 commented Nov 23, 2021

@pfn the problem is that the TFT initial state is FW_NOT_DETECTED. Only after connection is established, the state is changed. But in case of non RFF, message is sent by RRF code causing a continuous error message

@pfn
Copy link
Contributor

pfn commented Nov 23, 2021

It was intentional as the expectation was that marlin and other firmwares understand checksums (it's a standard). Thanks for fixing it, will need to add a config option for sending checksums even when the firmware is not yet detected.

@r00t4rd3d
Copy link

I just flashed the latest firmware for the TFT35 v3.0 and now my printer wont start. Says stuff about Liner number not being last line number. I had to revert to firmware from a couple months ago to fix it.

IMG_20211123_135459996

@aldaw
Copy link

aldaw commented Nov 24, 2021

I just flashed the latest firmware for the TFT35 v3.0 and now my printer wont start. Says stuff about Liner number not being last line number. I had to revert to firmware from a couple months ago to fix it.

IMG_20211123_135459996

Dito, i have the same problem, i thought i was because of marlin but after 3 diffrent .x versions i guess it is the firmware for the screen.

@pfn
Copy link
Contributor

pfn commented Nov 24, 2021

Yep, this is my bad, should have set the first line number to be sent as 1, instead it's 0, and that causes this error.

@pfn
Copy link
Contributor

pfn commented Nov 24, 2021

https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/pull/2250/files#diff-edea03df047c28a4f27608dbf5360fd4ab229b4cf35667fc89761e74b37f8980R6 this could be fixed by initializing line_number to 0, or pre-incrementing with ++line_number

@aldaw
Copy link

aldaw commented Nov 24, 2021

https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/pull/2250/files#diff-edea03df047c28a4f27608dbf5360fd4ab229b4cf35667fc89761e74b37f8980R6 this could be fixed by initializing line_number to 0, or pre-incrementing with ++line_number

So I would have to compile it i guess that i can test it?
Or could I try to use this command?
https://marlinfw.org/docs/gcode/M110.html
Example how i guess it:
M110 N0

@pfn
Copy link
Contributor

pfn commented Nov 24, 2021

@digant73 already "fixed" this by removing checksum lines for the not yet detected firmware case.

And it'd have to be M110 N-1 if that were possible.

@aldaw
Copy link

aldaw commented Nov 24, 2021

https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/pull/2250/files#diff-edea03df047c28a4f27608dbf5360fd4ab229b4cf35667fc89761e74b37f8980R6 this could be fixed by initializing line_number to 0, or pre-incrementing with ++line_number

I downloaded the source and compiled it, erros stayed.
Then i changed line_number to 1. Still in RRFSendCmd.c same message.
Now i would try to change line_number to -1, but i am loosing hope realizing i dunno what i am doing.
After flashing marlin, i have connection and can send with termial "M110 N-1. than seems like to work but only for short.

@aldaw
Copy link

aldaw commented Nov 24, 2021

@r00t4rd3d to wich version did you fall back? Where can i find it?

@r00t4rd3d
Copy link

r00t4rd3d commented Nov 24, 2021

@r00t4rd3d to wich version did you fall back? Where can i find it?

Go here:

https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware

Then click here:

Image1

Then click here:

Image2

This will bring you back to that release date. I can not remember the exact build I used, I just went back a couple months and used a Verified release. My printer is running right now so I cant check and see what version I am using.

@aldaw
Copy link

aldaw commented Nov 24, 2021

https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/pull/2250/files#diff-edea03df047c28a4f27608dbf5360fd4ab229b4cf35667fc89761e74b37f8980R6 this could be fixed by initializing line_number to 0, or pre-incrementing with ++line_number

I tried now also pre-incrementing with ++line_number instead of line_number.
Either I am to stupid or some thing else is missing :P

@aldaw
Copy link

aldaw commented Nov 24, 2021

@r00t4rd3d to wich version did you fall back? Where can i find it?

Go here:

https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware

Then click here:

Image1

Then click here:

Image2

This will bring you back to that release date. I can not remember the exact build I used, I just went back a couple months and used a Verified release. My printer is running right now so I cant check and see what version I am using.

Thank you so endless much a lot <3 was looking for version histories on github for a long time!
Will try it after i got some sleep, tried to fix that for 5 hours xD

@pfn
Copy link
Contributor

pfn commented Nov 24, 2021

@aldaw

I tried now also pre-incrementing with ++line_number instead of line_number. Either I am to stupid or some thing else is missing :P

it's kind of an annoyance, but marlin numbers will march on, so if the number gets out of sync, this error happens (reboot marlin w/o tft, or vice versa). it could probably be a more comprehensive fix with checksums always being sent by reading that error message, and updating the line number for future commands. for now, it's easier to just disable sending checksums if it's not RRF (RRF doesn't care about the line number really)

@aldaw
Copy link

aldaw commented Nov 25, 2021

For anyone who encounters the same bug. i used like @r00t4rd3d said a older version.
To be specific from Nov 11, 2021 and now i works like a charm nothing annoying! :)
Here a link for faster use https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/tree/78c41d021ad0cb1330eabaa8c90e6c95b6824dd4

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
6 participants