New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] TFT no more able to connect to Marlin #2255
Comments
I always wanted to write you this once. Please help the community and close the ticket once you do not need it anymore. Thank you 🤗 |
That's interesting, checksums should still work on non-RRF firmwares. I wonder why not... maybe it's the missing line-number reset. I guess this will have to be a specific config.ini option, sadly :( |
Well, for now there is nothing specific in rrf config.ini so there is place for it… :D |
@pfn the problem is that the TFT initial state is FW_NOT_DETECTED. Only after connection is established, the state is changed. But in case of non RFF, message is sent by RRF code causing a continuous error message |
It was intentional as the expectation was that marlin and other firmwares understand checksums (it's a standard). Thanks for fixing it, will need to add a config option for sending checksums even when the firmware is not yet detected. |
Dito, i have the same problem, i thought i was because of marlin but after 3 diffrent .x versions i guess it is the firmware for the screen. |
Yep, this is my bad, should have set the first line number to be sent as 1, instead it's 0, and that causes this error. |
https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/pull/2250/files#diff-edea03df047c28a4f27608dbf5360fd4ab229b4cf35667fc89761e74b37f8980R6 this could be fixed by initializing line_number to 0, or pre-incrementing with ++line_number |
So I would have to compile it i guess that i can test it? |
@digant73 already "fixed" this by removing checksum lines for the not yet detected firmware case. And it'd have to be M110 N-1 if that were possible. |
I downloaded the source and compiled it, erros stayed. |
@r00t4rd3d to wich version did you fall back? Where can i find it? |
Go here: https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware Then click here: Then click here: This will bring you back to that release date. I can not remember the exact build I used, I just went back a couple months and used a Verified release. My printer is running right now so I cant check and see what version I am using. |
I tried now also pre-incrementing with ++line_number instead of line_number. |
Thank you so endless much a lot <3 was looking for version histories on github for a long time! |
it's kind of an annoyance, but marlin numbers will march on, so if the number gets out of sync, this error happens (reboot marlin w/o tft, or vice versa). it could probably be a more comprehensive fix with checksums always being sent by reading that error message, and updating the line number for future commands. for now, it's easier to just disable sending checksums if it's not RRF (RRF doesn't care about the line number really) |
For anyone who encounters the same bug. i used like @r00t4rd3d said a older version. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Just to avoid panic, last merged PR #2250 made the TFT not able to connect to mainboard at startup for any fw different than RepRap.
The issue is already fixed by PR #2241
The text was updated successfully, but these errors were encountered: