Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migration from attrs to pydantic (#49) #65

Merged
merged 4 commits into from Nov 1, 2023

Conversation

holtgrewe
Copy link
Contributor

No description provided.

@holtgrewe holtgrewe linked an issue Nov 1, 2023 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Please format your code with black: make black.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (d1c86d4) 62.04% compared to head (ecbd2e2) 79.84%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #65       +/-   ##
===========================================
+ Coverage   62.04%   79.84%   +17.79%     
===========================================
  Files          19       19               
  Lines        1444     1424       -20     
===========================================
+ Hits          896     1137      +241     
+ Misses        548      287      -261     
Files Coverage Δ
varfish_cli/api/models.py 100.00% <100.00%> (ø)
varfish_cli/api/project.py 100.00% <100.00%> (ø)
varfish_cli/api/varannos.py 100.00% <100.00%> (ø)
varfish_cli/cli/common.py 89.90% <100.00%> (ø)
varfish_cli/cli/importer/__init__.py 92.15% <100.00%> (+10.15%) ⬆️
varfish_cli/cli/varannos.py 100.00% <100.00%> (ø)
varfish_cli/common.py 87.71% <ø> (+0.76%) ⬆️
varfish_cli/parse_ped.py 100.00% <100.00%> (ø)
varfish_cli/cli/importer/create.py 77.24% <50.00%> (+51.87%) ⬆️
varfish_cli/api/case.py 50.69% <78.26%> (+22.48%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holtgrewe holtgrewe merged commit 2c9e402 into main Nov 1, 2023
12 checks passed
@holtgrewe holtgrewe deleted the 49-migrate-to-pydantic-rather-than-attrs branch November 1, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to pydantic rather than attrs
1 participant