Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safari? #4

Closed
controversial opened this issue Jan 22, 2017 · 6 comments
Closed

Safari? #4

controversial opened this issue Jan 22, 2017 · 6 comments

Comments

@controversial
Copy link

This seems to work in Chrome but not safari, however no errors are raised, the script fails silently 😕
@bijection
Copy link
Owner

What version of safari and OSX are you using?

@bijection
Copy link
Owner

Never mind, it was broken on all versions of safari. Should be fixed now!

@controversial
Copy link
Author

controversial commented Jan 22, 2017 •
edited
Loading

Wow, that was fast, thanks! What was the fix? Does Safari just not support base64 PNG rendering on canvas?

@bijection
Copy link
Owner

I'm not exactly sure, but the first getimagedata, which was supposed to extract the opacities for the smoke sprite, was returning completely zero. It may be that safari doesn't load base64 encoded srcs synchronously.

@controversial
Copy link
Author

Ah, that sounds likely. Thanks!

@bijection
Copy link
Owner

Either way it's a more sane implementation now anyways 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bijection @controversial