Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we get a dark version of this theme? #28

Open
cruhl opened this issue Apr 13, 2017 · 4 comments
Open

Can we get a dark version of this theme? #28

cruhl opened this issue Apr 13, 2017 · 4 comments

Comments

@cruhl
Copy link

cruhl commented Apr 13, 2017

This theme is awesome, but I'd love dark version for low light situations. Thanks for your work!

@biletskyy
Copy link
Owner

@cruhl I thought a lot about dark variant of this theme. But i came to conclusion that dark theme with colored backgrounds will not look good.

The reason is simple. Colors look best when they are bright/light. Light colored text looks good on dark background. That's why there are so many good looking dark themes. And that's why light themes don't look so good. If you have light background you need to make dark text. If you make it really dark, then colors become dull. If you make bright colors, then you loose contrast.

@ghost
Copy link

ghost commented Nov 27, 2017

I have to second biletskyy on this -- I tried making my own dark theme similar to flatwhite and it just looked awful.

@Bertg
Copy link

Bertg commented Feb 26, 2018

Hi there,

I put 5 minutes of thought int this, and I was wondering if a dark variant of this could work if instead of highlighting the characters, they would

  • Be underlined
  • Be "boxed"

Anyone gave that a shot?

@charignon
Copy link

Thank for the flatwhite theme it is awesome. You can try twilight-anti-bright if you are looking at an example of a dark theme with background highlighted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants