Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it good attaching flv Object to window? #9

Closed
p2227 opened this issue Oct 28, 2016 · 1 comment
Closed

Is it good attaching flv Object to window? #9

p2227 opened this issue Oct 28, 2016 · 1 comment

Comments

@p2227
Copy link

p2227 commented Oct 28, 2016 •
edited

https://github.com/Bilibili/flv.js/blob/5176f5d935c41a1ee8dbd9eca65b3a6fe7df6b9e/src/flv.js#L81

I think this code should only appearance in dist code and produced by “gulp build” or similar task.

use this: https://www.npmjs.com/package/babel-plugin-transform-es2015-modules-umd
@xqq
Copy link
Contributor

xqq commented Nov 2, 2016

Fixed in 190a597
I think babel-plugin-transform-es2015-modules-umd may cause each js file to be wrapped by a umd wrapper. Then I found browserify can do this easily.

Thank you.

@xqq xqq closed this as completed Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@p2227 @xqq