Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torrent list won't refresh if every torrent is on pause and you delete something #128

Closed
Ansem93 opened this issue Aug 11, 2021 · 15 comments · Fixed by #143
Closed

Torrent list won't refresh if every torrent is on pause and you delete something #128

Ansem93 opened this issue Aug 11, 2021 · 15 comments · Fixed by #143
Labels
bug Something isn't working

Comments

@Ansem93
Copy link

Ansem93 commented Aug 11, 2021

Describe the bug
If every file is in "paused" when you delete it you need to reload the page to see the effect

To Reproduce
Steps to reproduce the behavior:

  1. Wait for every file to be on pause
  2. delete a file
  3. nothing happen

Expected behavior
The file list should update to show that the file is deleted

Actual behavior
The page won't refresh. If you delete it when something is download there are no issues.

Desktop (please complete the following information):
MatUI: 1.12
Firefox: 91

@Ansem93 Ansem93 added the bug Something isn't working label Aug 11, 2021
@bill-ahmed
Copy link
Owner

Was able to reproduce again in Chrome. This seems to be a pretty weird issue, will investigate further when I get the chance.

@Ansem93
Copy link
Author

Ansem93 commented Aug 16, 2021

I think that this is how it goes:

  1. Every download is stalled (completed, in queue, etc.) so it doesn't make traffic
  2. No traffic, no need to update the UI -> this is actually good, no resource wasted
  3. Deleting a file won't trigger a manuale refresh, so we won't see any change until we reload the page

Maybe just add that after deleting a torrent it will launch a manual refresh of the UI?

@bill-ahmed
Copy link
Owner

I've only been able to reproduce in Paused state so far, but yea doing a full refresh on delete might be the quickest way to fix it. Sorry have been busy with work lately so unable to respond as quickly as i'd like.

@bill-ahmed
Copy link
Owner

@Ansem93 I think it was able to trace it down to a race condition, but weirdly as of this morning i'm unable to reproduce it even after several attempts.

@Ansem93
Copy link
Author

Ansem93 commented Aug 30, 2021

Do you need any help to find it again? If I can help I will do it :)

@bill-ahmed
Copy link
Owner

Do you need any help to find it again? If I can help I will do it :)

I've tried again, still unable to reproduce....one thing I did change was updating to a newer version of qBittorrent. What version are on atm?

@bill-ahmed
Copy link
Owner

Nevermind i'm able to reproduce it again, realized what I was missing.

@Ansem93
Copy link
Author

Ansem93 commented Sep 2, 2021

I think something still changed. After updating to 4.3.8 I wasn't able to reproduce it again.
I think what changed is this:
WEBUI: Improve "last activity" calculation in WebAPI (#15339) (Chocobo1)

@bill-ahmed
Copy link
Owner

Okay that is pretty weird. If you're unable to reproduce it please close this issue. If something like this pops up again in the future we can always re-open or create another one :)

@bill-ahmed
Copy link
Owner

Closing as per last comment.

@Ansem93
Copy link
Author

Ansem93 commented Oct 23, 2021

Sorry to re-open this issue, but it's still there :( How I got it:
Firefox 93
qBittorrent
Build: v4.3.8 .
API: v2.8.2 .
Material Web UI
You are on v1.14.0

  • I had two files in status seeding
  • I delete one of them -> fine
  • I deleted the last one ->the page didn't update

@bill-ahmed bill-ahmed reopened this Oct 24, 2021
@Ansem93
Copy link
Author

Ansem93 commented Oct 24, 2021

Other example since it happened again: I deleted all the torrents at once (this time using "delete the files"), after doing so it didn't refresh

@bill-ahmed
Copy link
Owner

With the new torrent table implementation, we might be able to just do a hard-reset on the entire list without taking a performance penalty. Will try and reproduce both scenarios.

@bill-ahmed
Copy link
Owner

@Ansem93 i've pinpointed the issue, it was prematurely exiting before making a note of all the torrents that were deleted. This was an edge where, if no torrents were changed then it wouldn't even bother to remove those that were deleted.

This also explains why it was easily reproducible by pausing all torrents. When they're in the paused state, no new properties are sent over. It should be fixed in the next release :)

@bill-ahmed bill-ahmed linked a pull request Oct 25, 2021 that will close this issue
@bill-ahmed
Copy link
Owner

@Ansem93 This will be released in 1.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants