-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Torrent list won't refresh if every torrent is on pause and you delete something #128
Comments
Was able to reproduce again in Chrome. This seems to be a pretty weird issue, will investigate further when I get the chance. |
I think that this is how it goes:
Maybe just add that after deleting a torrent it will launch a manual refresh of the UI? |
I've only been able to reproduce in Paused state so far, but yea doing a full refresh on delete might be the quickest way to fix it. Sorry have been busy with work lately so unable to respond as quickly as i'd like. |
@Ansem93 I think it was able to trace it down to a race condition, but weirdly as of this morning i'm unable to reproduce it even after several attempts. |
Do you need any help to find it again? If I can help I will do it :) |
I've tried again, still unable to reproduce....one thing I did change was updating to a newer version of qBittorrent. What version are on atm? |
Nevermind i'm able to reproduce it again, realized what I was missing. |
I think something still changed. After updating to 4.3.8 I wasn't able to reproduce it again. |
Okay that is pretty weird. If you're unable to reproduce it please close this issue. If something like this pops up again in the future we can always re-open or create another one :) |
Closing as per last comment. |
Sorry to re-open this issue, but it's still there :( How I got it:
|
Other example since it happened again: I deleted all the torrents at once (this time using "delete the files"), after doing so it didn't refresh |
With the new torrent table implementation, we might be able to just do a hard-reset on the entire list without taking a performance penalty. Will try and reproduce both scenarios. |
@Ansem93 i've pinpointed the issue, it was prematurely exiting before making a note of all the torrents that were deleted. This was an edge where, if no torrents were changed then it wouldn't even bother to remove those that were deleted. This also explains why it was easily reproducible by pausing all torrents. When they're in the paused state, no new properties are sent over. It should be fixed in the next release :) |
@Ansem93 This will be released in |
Describe the bug
If every file is in "paused" when you delete it you need to reload the page to see the effect
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The file list should update to show that the file is deleted
Actual behavior
The page won't refresh. If you delete it when something is download there are no issues.
Desktop (please complete the following information):
MatUI: 1.12
Firefox: 91
The text was updated successfully, but these errors were encountered: